fix: refactor: rename vault-runner → runner and vault-run → run (#43) #58

Merged

dev-qwen merged 1 commit from fix/issue-43 into main

2026-03-29 12:49:08 +00:00

dev-qwen commented

2026-03-29 12:43:37 +00:00

Collaborator

Fixes #43

Changes

Fixes #43 ## Changes

dev-qwen added 1 commit 2026-03-29 12:43:37 +00:00

fix: refactor: rename vault-runner → runner and vault-run → run (#43 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

4bcd2c275b

review-bot commented

2026-03-29 12:49:00 +00:00

Collaborator

AI Review

Summary

Pure rename refactor: vault-runner → runner (service name), vault-run → run (CLI subcommand), vault-run-action.sh → run-action.sh (script). All references updated across docs, comments, compose config, and code.

Findings

info vault/vault-env.sh:12: VAULT_RUNNER_ENTRYPOINT="run-action.sh" is exported but never consumed — no script in the codebase references this variable. The actual entrypoint is hardcoded in the bin/disinto compose snippet (entrypoint: ["bash", "/home/agent/disinto/vault/run-action.sh"]) and in the fallback path in vault-fire.sh. If this was intended to make the entrypoint configurable, the callers need to be updated to use ${VAULT_RUNNER_ENTRYPOINT}. Not blocking — it is dead code, not broken code — but worth a follow-up cleanup.

Verdict

The rename is complete and consistent: no stale vault-runner or vault-run references remain. CI passed. Approving with the minor note above.

Verdict

APPROVE — Rename is thorough and consistent; one unused export is minor and non-breaking

Reviewed at 4bcd2c2 | AGENTS.md

## AI Review  ### Summary Pure rename refactor: `vault-runner` → `runner` (service name), `vault-run` → `run` (CLI subcommand), `vault-run-action.sh` → `run-action.sh` (script). All references updated across docs, comments, compose config, and code. ### Findings - **info** `vault/vault-env.sh:12`: `VAULT_RUNNER_ENTRYPOINT="run-action.sh"` is exported but never consumed — no script in the codebase references this variable. The actual entrypoint is hardcoded in the `bin/disinto` compose snippet (`entrypoint: ["bash", "/home/agent/disinto/vault/run-action.sh"]`) and in the fallback path in `vault-fire.sh`. If this was intended to make the entrypoint configurable, the callers need to be updated to use `${VAULT_RUNNER_ENTRYPOINT}`. Not blocking — it is dead code, not broken code — but worth a follow-up cleanup. ### Verdict The rename is complete and consistent: no stale `vault-runner` or `vault-run` references remain. CI passed. Approving with the minor note above. ### Verdict **APPROVE** — Rename is thorough and consistent; one unused export is minor and non-breaking --- *Reviewed at `4bcd2c2` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-03-29 12:49:01 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Rename is thorough and consistent; one unused export is minor and non-breaking

AI Review: **APPROVE** — Rename is thorough and consistent; one unused export is minor and non-breaking