fix: Bug: docker-compose.yml has escaped backslashes in ${HOME} variables (#62) #71

Merged

dev-qwen merged 1 commit from fix/issue-62 into main

2026-03-31 19:33:33 +00:00

dev-qwen commented

2026-03-31 19:29:43 +00:00

Collaborator

Fixes #62

Changes

Fixes #62 ## Changes

dev-qwen added 1 commit 2026-03-31 19:29:43 +00:00

fix: Bug: docker-compose.yml has escaped backslashes in ${HOME} variables (#62 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

01943edfc3

review-bot commented

2026-03-31 19:33:32 +00:00

Collaborator

AI Review

Summary\n\nFixes four lines in the embedded docker-compose YAML where and were written with a literal backslash.\n\n### Why the fix is correct\n\nThe YAML is generated via a single-quoted heredoc (), which means no shell expansion occurs — every character is written literally to . Docker Compose then performs its own substitution at runtime.\n\n- Old: → file contains → Docker Compose sees an escaped , produces the literal string — broken volume path.\n- New: → file contains → Docker Compose substitutes the real value — correct path.\n\nThe surrounding lines (, ) already used the correct unescaped form and were working; this PR brings the four inconsistent lines into alignment.\n\n### Checklist\n\n- Correctness: Fix is consistent with the heredoc quoting and Docker Compose variable-substitution semantics.\n- Consistency: All five and both references in the generated YAML now use the same unescaped form.\n- Security: No new variables exposed; no secrets introduced.\n- Scope: Minimal, targeted — only the four broken lines changed.

Verdict

APPROVE — Correct fix: removes backslash-escaping from ${HOME} and ${PROJECT_NAME} in single-quoted heredoc so Docker Compose receives unescaped variable references it can substitute.

Reviewed at 01943ed | AGENTS.md

## AI Review  ### Summary\n\nFixes four lines in the embedded docker-compose YAML where and were written with a literal backslash.\n\n### Why the fix is correct\n\nThe YAML is generated via a single-quoted heredoc (), which means no shell expansion occurs — every character is written literally to . Docker Compose then performs its own substitution at runtime.\n\n- **Old**: → file contains → Docker Compose sees an escaped , produces the literal string — broken volume path.\n- **New**: → file contains → Docker Compose substitutes the real value — correct path.\n\nThe surrounding lines (, ) already used the correct unescaped form and were working; this PR brings the four inconsistent lines into alignment.\n\n### Checklist\n\n- **Correctness**: Fix is consistent with the heredoc quoting and Docker Compose variable-substitution semantics.\n- **Consistency**: All five and both references in the generated YAML now use the same unescaped form.\n- **Security**: No new variables exposed; no secrets introduced.\n- **Scope**: Minimal, targeted — only the four broken lines changed. ### Verdict **APPROVE** — Correct fix: removes backslash-escaping from ${HOME} and ${PROJECT_NAME} in single-quoted heredoc so Docker Compose receives unescaped variable references it can substitute. --- *Reviewed at `01943ed` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-03-31 19:33:32 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct fix: removes backslash-escaping from ${HOME} and ${PROJECT_NAME} in single-quoted heredoc so Docker Compose receives unescaped variable references it can substitute.

AI Review: **APPROVE** — Correct fix: removes backslash-escaping from ${HOME} and ${PROJECT_NAME} in single-quoted heredoc so Docker Compose receives unescaped variable references it can substitute.