review-bot
  • Joined on 2026-03-28
review-bot approved johba/disinto#130 2026-04-01 20:28:51 +00:00
fix: bug: dispatcher PR lookup fails — --diff-filter=A misses merge commits (#129)

AI Re-review (round 2): APPROVE — Previous finding fixed: --reverse added so head -1 returns the oldest (direct PR) merge commit, not the newest

review-bot commented on pull request johba/disinto#130 2026-04-01 20:28:50 +00:00
fix: bug: dispatcher PR lookup fails — --diff-filter=A misses merge commits (#129)

AI Re-review (round 2)

Previous Findings\n\n- medium dispatcher.sh:123-124head -1 returns newest merge commit…

review-bot commented on pull request johba/disinto#130 2026-04-01 20:17:46 +00:00
fix: bug: dispatcher PR lookup fails — --diff-filter=A misses merge commits (#129)

AI Review

Summary

This PR fixes two real bugs and adds missing compose env vars:

  1. get_pr_for_file rewrite — The…
review-bot suggested changes for johba/disinto#130 2026-04-01 20:17:46 +00:00
fix: bug: dispatcher PR lookup fails — --diff-filter=A misses merge commits (#129)

AI Review: REQUEST_CHANGES — get_pr_for_file uses head -1 on the merge-commit log, returning the newest merge instead of the direct PR merge commit

review-bot approved johba/disinto#128 2026-04-01 19:40:40 +00:00
fix: refactor: simplify gardener formula — remove AD check, portfolio, blocked-review, stale-PR (#127)

AI Review: APPROVE — Clean simplification: removes unused steps, fixes vault template to use vault_request(), and correctly syncs AGENTS.md

review-bot commented on pull request johba/disinto#128 2026-04-01 19:40:39 +00:00
fix: refactor: simplify gardener formula — remove AD check, portfolio, blocked-review, stale-PR (#127)

AI Review

Summary

Non-code PR (formula/docs only) — CI not required.

Removes four gardener steps (blocked-review, stale-pr-re…

review-bot approved johba/disinto#125 2026-04-01 19:13:24 +00:00
fix: feat: Forgejo API mock server for CI smoke tests (#123)

AI Re-review (round 2): APPROVE — All four previous findings fixed; one residual minor issue with HTTP shutdown endpoint not calling server.shutdown()

review-bot commented on pull request johba/disinto#125 2026-04-01 19:13:23 +00:00
fix: feat: Forgejo API mock server for CI smoke tests (#123)

AI Re-review (round 2)

Previous Findings

  • Collaborator PUT wrong path index → FIXED: guard changed to len(parts) >= 8,…
review-bot suggested changes for johba/disinto#125 2026-04-01 19:05:52 +00:00
fix: feat: Forgejo API mock server for CI smoke tests (#123)

AI Review: REQUEST_CHANGES — Four functional bugs: collaborator index wrong, user/repos owner lookup broken, /mock/shutdown unreachable, SIGTERM doesn't stop server

review-bot commented on pull request johba/disinto#125 2026-04-01 19:05:51 +00:00
fix: feat: Forgejo API mock server for CI smoke tests (#123)

AI Review

Summary

New mock Forgejo server for CI smoke tests. Good overall structure with threaded server, in-memory state, and…

review-bot approved johba/disinto#122 2026-04-01 18:32:27 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Re-review (round 2): APPROVE — Previous finding fixed: COPY entrypoint.sh updated to docker/agents/entrypoint.sh for root build context

review-bot commented on pull request johba/disinto#122 2026-04-01 18:32:26 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Re-review (round 2)

Previous Findings

  • bug docker/agents/Dockerfile:26COPY entrypoint.sh fails with root build…
review-bot suggested changes for johba/disinto#122 2026-04-01 18:25:14 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Review: REQUEST_CHANGES — COPY entrypoint.sh fails with new root build context — file is at docker/agents/entrypoint.sh, not repo root

review-bot commented on pull request johba/disinto#122 2026-04-01 18:25:13 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Review

Summary

This PR fixes the SOPS/tea download failure in Docker-in-LXD builds by pre-downloading binaries to `docker/age…

review-bot approved johba/disinto#121 2026-04-01 18:04:29 +00:00
fix: bug: dispatcher fails in edge container — lib/env.sh not available (#119)

AI Review: APPROVE — Clean fix: entrypoint-based repo clone correctly makes lib/env.sh available to dispatcher at runtime

review-bot commented on pull request johba/disinto#121 2026-04-01 18:04:28 +00:00
fix: bug: dispatcher fails in edge container — lib/env.sh not available (#119)

AI Review

Summary\n\nThe bug: was volume-mounted as a single file into the edge container, but it sources lib/env.sh via a…

review-bot commented on pull request johba/disinto#118 2026-04-01 15:21:51 +00:00
fix: bug: dev-agent does not clean up branch/worktree on CI exhausted or block (#115)

AI Review

Summary

This PR adds the missing resource cleanup (PR close, remote branch delete, worktree removal, temp file…

review-bot approved johba/disinto#118 2026-04-01 15:21:51 +00:00
fix: bug: dev-agent does not clean up branch/worktree on CI exhausted or block (#115)

AI Review: APPROVE — Correctly adds missing cleanup for failure path; logic and patterns are sound

review-bot commented on pull request johba/disinto#117 2026-04-01 15:07:30 +00:00
fix: bug: disinto init does not set up human user as site admin or ops repo collaborator (#113)

AI Re-review (round 2)

Previous Findings

  • ${human_user} unbound variable in setup_ops_repo (bin/disinto:951) →…
review-bot approved johba/disinto#117 2026-04-01 15:07:30 +00:00
fix: bug: disinto init does not set up human user as site admin or ops repo collaborator (#113)

AI Re-review (round 2): APPROVE — unbound variable bug fixed by replacing ${human_user} with literal 'johba' in setup_ops_repo