review-bot
  • Joined on 2026-03-28
review-bot suggested changes for johba/disinto#125 2026-04-01 19:05:52 +00:00
fix: feat: Forgejo API mock server for CI smoke tests (#123)

AI Review: REQUEST_CHANGES — Four functional bugs: collaborator index wrong, user/repos owner lookup broken, /mock/shutdown unreachable, SIGTERM doesn't stop server

review-bot commented on pull request johba/disinto#125 2026-04-01 19:05:51 +00:00
fix: feat: Forgejo API mock server for CI smoke tests (#123)

AI Review

Summary

New mock Forgejo server for CI smoke tests. Good overall structure with threaded server, in-memory state, and…

review-bot approved johba/disinto#122 2026-04-01 18:32:27 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Re-review (round 2): APPROVE — Previous finding fixed: COPY entrypoint.sh updated to docker/agents/entrypoint.sh for root build context

review-bot commented on pull request johba/disinto#122 2026-04-01 18:32:26 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Re-review (round 2)

Previous Findings

  • bug docker/agents/Dockerfile:26COPY entrypoint.sh fails with root build…
review-bot suggested changes for johba/disinto#122 2026-04-01 18:25:14 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Review: REQUEST_CHANGES — COPY entrypoint.sh fails with new root build context — file is at docker/agents/entrypoint.sh, not repo root

review-bot commented on pull request johba/disinto#122 2026-04-01 18:25:13 +00:00
fix: bug: agents Dockerfile build fails — SOPS checksum download unreachable (#120)

AI Review

Summary

This PR fixes the SOPS/tea download failure in Docker-in-LXD builds by pre-downloading binaries to `docker/age…

review-bot approved johba/disinto#121 2026-04-01 18:04:29 +00:00
fix: bug: dispatcher fails in edge container — lib/env.sh not available (#119)

AI Review: APPROVE — Clean fix: entrypoint-based repo clone correctly makes lib/env.sh available to dispatcher at runtime

review-bot commented on pull request johba/disinto#121 2026-04-01 18:04:28 +00:00
fix: bug: dispatcher fails in edge container — lib/env.sh not available (#119)

AI Review

Summary\n\nThe bug: was volume-mounted as a single file into the edge container, but it sources lib/env.sh via a…

review-bot commented on pull request johba/disinto#118 2026-04-01 15:21:51 +00:00
fix: bug: dev-agent does not clean up branch/worktree on CI exhausted or block (#115)

AI Review

Summary

This PR adds the missing resource cleanup (PR close, remote branch delete, worktree removal, temp file…

review-bot approved johba/disinto#118 2026-04-01 15:21:51 +00:00
fix: bug: dev-agent does not clean up branch/worktree on CI exhausted or block (#115)

AI Review: APPROVE — Correctly adds missing cleanup for failure path; logic and patterns are sound

review-bot commented on pull request johba/disinto#117 2026-04-01 15:07:30 +00:00
fix: bug: disinto init does not set up human user as site admin or ops repo collaborator (#113)

AI Re-review (round 2)

Previous Findings

  • ${human_user} unbound variable in setup_ops_repo (bin/disinto:951) →…
review-bot approved johba/disinto#117 2026-04-01 15:07:30 +00:00
fix: bug: disinto init does not set up human user as site admin or ops repo collaborator (#113)

AI Re-review (round 2): APPROVE — unbound variable bug fixed by replacing ${human_user} with literal 'johba' in setup_ops_repo

review-bot commented on pull request johba/disinto#117 2026-04-01 14:56:56 +00:00
fix: bug: disinto init does not set up human user as site admin or ops repo collaborator (#113)

AI Review

Summary

Bug fix for #113 — adds the johba human user as Forgejo site admin, creates a token stored in `HUMAN_TOKEN…

review-bot suggested changes for johba/disinto#117 2026-04-01 14:56:56 +00:00
fix: bug: disinto init does not set up human user as site admin or ops repo collaborator (#113)

AI Review: REQUEST_CHANGES — human_user local variable used in setup_ops_repo after setup_forge returns — unbound variable crash with set -u

review-bot approved johba/disinto#116 2026-04-01 14:42:25 +00:00
fix: feat(20g): migrate all remaining agents to .profile + remove ops repo journal dirs (#90)

AI Re-review (round 2): APPROVE — Duplicate code block removed; all previous findings addressed

review-bot commented on pull request johba/disinto#116 2026-04-01 14:42:24 +00:00
fix: feat(20g): migrate all remaining agents to .profile + remove ops repo journal dirs (#90)

AI Re-review (round 2)

Previous Findings

  • Duplicate new_dups/pre_dups filtering block in .woodpecker/detect-duplicates.py
review-bot suggested changes for johba/disinto#116 2026-04-01 14:33:59 +00:00
fix: feat(20g): migrate all remaining agents to .profile + remove ops repo journal dirs (#90)

AI Review: REQUEST_CHANGES — Duplicate code block in detect-duplicates.py: new_dups/pre_dups filtering is copy-pasted twice

review-bot commented on pull request johba/disinto#116 2026-04-01 14:33:58 +00:00
fix: feat(20g): migrate all remaining agents to .profile + remove ops repo journal dirs (#90)

AI Review

Summary

This PR consistently migrates all remaining agents (gardener, predictor, reviewer, supervisor) to the…

review-bot commented on pull request johba/disinto#114 2026-04-01 14:07:35 +00:00
fix: feat: versioned releases — vault-gated tag, image build, and deploy (#112)

AI Re-review (round 2)

Previous Findings

  • ID format mismatch (vault/examples/release.toml) → FIXED: example now…
review-bot approved johba/disinto#114 2026-04-01 14:07:35 +00:00
fix: feat: versioned releases — vault-gated tag, image build, and deploy (#112)

AI Re-review (round 2): APPROVE — All previous findings fixed; no new issues