review-bot
  • Joined on 2026-03-28
review-bot commented on pull request johba/disinto#37 2026-03-28 19:18:31 +00:00
fix: feat: disinto secrets migrate — encrypt existing plaintext .env (#33)

AI Review

Summary\n\nThe PR adds a safety guard to the secrets migrate subcommand: after encrypting .env to .env.enc, it…

review-bot approved johba/disinto#37 2026-03-28 19:18:31 +00:00
fix: feat: disinto secrets migrate — encrypt existing plaintext .env (#33)

AI Review: APPROVE — Adds correct post-encrypt verification to prevent data loss during migrate

review-bot commented on pull request johba/disinto#35 2026-03-28 19:12:27 +00:00
fix: feat: disinto secrets add — store individual encrypted secrets (#31)

AI Re-review (round 2)

Previous Findings

  • high terminal echo on secret input → FIXED: IFS= read -rs value + `echo…
review-bot approved johba/disinto#35 2026-03-28 19:12:27 +00:00
fix: feat: disinto secrets add — store individual encrypted secrets (#31)

AI Re-review (round 2): APPROVE — Both previous findings addressed: silent read and overwrite guard are now in place

review-bot suggested changes for johba/disinto#35 2026-03-28 19:08:07 +00:00
fix: feat: disinto secrets add — store individual encrypted secrets (#31)

AI Review: REQUEST_CHANGES — read -r does not suppress terminal echo — secret value is visible to anyone watching the screen

review-bot commented on pull request johba/disinto#35 2026-03-28 19:08:06 +00:00
fix: feat: disinto secrets add — store individual encrypted secrets (#31)

AI Review

Security

  • high bin/disinto:2061: IFS= read -r value does not suppress terminal echo. The typed secret will…
review-bot approved johba/disinto#36 2026-03-28 19:03:50 +00:00
fix: fix: mount age key directory into agents containers (#32)

AI Review: APPROVE — Correct minimal fix: mounts the host age key directory read-only into agents, consistent with existing patterns and matching the path used by ensure_age_key()

review-bot commented on pull request johba/disinto#36 2026-03-28 19:03:49 +00:00
fix: fix: mount age key directory into agents containers (#32)

AI Review

Summary

This PR fixes #32 by mounting the SOPS/age key directory (${HOME}/.config/sops/age) into the agents…

review-bot commented on pull request johba/disinto#27 2026-03-28 16:45:08 +00:00
fix: fix: remove PROMPT.md files — formulas are the source of truth (#12)

AI Review

Summary

This PR removes , , and , replacing them with formula TOML files as the single source of truth. All shell…

review-bot approved johba/disinto#27 2026-03-28 16:45:08 +00:00
fix: fix: remove PROMPT.md files — formulas are the source of truth (#12)

AI Review: APPROVE — Clean migration: PROMPT.md files removed, all references updated, run-vault.toml formula correctly mirrors old vault/PROMPT.md content

review-bot commented on pull request johba/disinto#18 2026-03-28 15:13:10 +00:00
fix: fix: review-poll.sh still uses tmux for session cleanup and injection (#11)

AI Review

Summary

This PR completes the migration of review-poll.sh away from tmux by:

  1. Replacing tmux session enumeration…
review-bot approved johba/disinto#18 2026-03-28 15:13:10 +00:00
fix: fix: review-poll.sh still uses tmux for session cleanup and injection (#11)

AI Review: APPROVE — Correctly removes all tmux usage from review-poll.sh, replacing session discovery with .sid files and dropping the inject function that is no longer needed

review-bot commented on pull request johba/disinto#17 2026-03-28 13:31:35 +00:00
fix: Migrate planner, predictor, supervisor to SDK (#6)

AI Review

Summary

Migrates planner, predictor, and supervisor from the tmux/phase-file orchestration pattern to synchronous…

review-bot approved johba/disinto#17 2026-03-28 13:31:35 +00:00
fix: Migrate planner, predictor, supervisor to SDK (#6)

AI Review: APPROVE — Clean, consistent migration of planner/predictor/supervisor from tmux+phase-file to SDK pattern; new helpers are correct and well-factored

review-bot commented on pull request johba/disinto#13 2026-03-28 11:23:21 +00:00
fix: Migrate action-agent.sh to SDK + shared libraries (#5)

AI Review

Summary

This PR migrates from the tmux + phase-file model to the synchronous SDK model, matching the pattern…

review-bot approved johba/disinto#13 2026-03-28 11:23:21 +00:00
fix: Migrate action-agent.sh to SDK + shared libraries (#5)

AI Review: APPROVE — Clean SDK migration: correct logic, shared libraries used properly, no bugs found.