fix: dev-poll 'my thread is busy' exits without checking for pending review feedback #411

New issue

Closed

opened 2026-04-08 09:13:16 +00:00 by dev-bot · 0 comments

dev-bot commented

2026-04-08 09:13:16 +00:00

Collaborator

Problem

dev-poll.sh line ~413: when an in-progress issue is assigned to the current agent, the poll logs 'my thread is busy' and exits immediately. It does not check if the issue's PR has REQUEST_CHANGES feedback waiting.

The REQUEST_CHANGES handling at lines ~511 and ~770 never executes because the in-progress exit happens first.

Result: after review requests changes on a PR, the dev agent never addresses the feedback. The issue stays in-progress forever with no agent working on it.

Fix

When 'my thread is busy', check if the issue's PR has REQUEST_CHANGES before exiting. If review feedback is pending, spawn the agent to address it instead of exiting:

if [ "$assignee" = "$me" ]; then
  # Check if my PR has review feedback to address
  if [ -n "$HAS_PR" ]; then
    review_state=$(...)  # check for REQUEST_CHANGES
    if [ "$review_state" = "REQUEST_CHANGES" ]; then
      log "issue #${ISSUE_NUM} has review feedback — spawning agent"
      # spawn agent to address review
      continue
    fi
  fi
  log "issue #${ISSUE_NUM} assigned to me — my thread is busy"
  exit 0
fi

Affected files

dev/dev-poll.sh (in-progress check section, around line 413)

Acceptance criteria

Dev agent addresses REQUEST_CHANGES on its own PRs automatically
No manual intervention needed to unblock review cycles
Agent still exits correctly when genuinely busy (agent process running)

## Problem dev-poll.sh line ~413: when an in-progress issue is assigned to the current agent, the poll logs 'my thread is busy' and exits immediately. It does not check if the issue's PR has REQUEST_CHANGES feedback waiting. The REQUEST_CHANGES handling at lines ~511 and ~770 never executes because the in-progress exit happens first. Result: after review requests changes on a PR, the dev agent never addresses the feedback. The issue stays in-progress forever with no agent working on it. ## Fix When 'my thread is busy', check if the issue's PR has REQUEST_CHANGES before exiting. If review feedback is pending, spawn the agent to address it instead of exiting: if [ "$assignee" = "$me" ]; then # Check if my PR has review feedback to address if [ -n "$HAS_PR" ]; then review_state=$(...) # check for REQUEST_CHANGES if [ "$review_state" = "REQUEST_CHANGES" ]; then log "issue #${ISSUE_NUM} has review feedback — spawning agent" # spawn agent to address review continue fi fi log "issue #${ISSUE_NUM} assigned to me — my thread is busy" exit 0 fi ## Affected files - dev/dev-poll.sh (in-progress check section, around line 413) ## Acceptance criteria - [ ] Dev agent addresses REQUEST_CHANGES on its own PRs automatically - [ ] No manual intervention needed to unblock review cycles - [ ] Agent still exits correctly when genuinely busy (agent process running)