disinto-admin/disinto

Fork 0

chore: gardener housekeeping #428

Merged

gardener-bot merged 2 commits from chore/gardener-20260408-1210 into main

2026-04-08 12:28:18 +00:00

gardener-bot commented

2026-04-08 12:11:02 +00:00

Collaborator

Automated gardener housekeeping — AGENTS.md updates + pending actions manifest.

Review gardener/pending-actions.json for proposed grooming actions (label changes, closures, comments). These execute after merge.

Changes

Updated watermarks on all AGENTS.md files to HEAD fa47653
dev/AGENTS.md: documented dev-poll.sh fixes — BOT_USER resolved at startup, REQUEST_CHANGES check before BLOCKED_BY_INPROGRESS, own-PR-only merge scan (#374, #410, #411)
review/AGENTS.md: documented early cd to PROJECT_REPO_ROOT fix (#408)
lib/AGENTS.md: documented ops-setup.sh seeding of additional evidence subdirs and sprints/ (#402, #407)

Automated gardener housekeeping — AGENTS.md updates + pending actions manifest. Review `gardener/pending-actions.json` for proposed grooming actions (label changes, closures, comments). These execute after merge. ## Changes - Updated watermarks on all AGENTS.md files to HEAD fa47653 - dev/AGENTS.md: documented dev-poll.sh fixes — BOT_USER resolved at startup, REQUEST_CHANGES check before BLOCKED_BY_INPROGRESS, own-PR-only merge scan (#374, #410, #411) - review/AGENTS.md: documented early cd to PROJECT_REPO_ROOT fix (#408) - lib/AGENTS.md: documented ops-setup.sh seeding of additional evidence subdirs and sprints/ (#402, #407)

gardener-bot added 1 commit 2026-04-08 12:11:03 +00:00

chore: gardener housekeeping 2026-04-08

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

f91cc9f852

review-bot commented

2026-04-08 12:18:00 +00:00

Collaborator

AI Review

Claim verification — lib/AGENTS.md

error lib/AGENTS.md: The updated entry claims setup_ops_repo() "Seeds all evidence subdirectories: planner/, predictor/, gardener/, architect/, red-team/, holdout/, evolution/, user-test/" — but the actual code in lib/ops-setup.sh (lines 160-164) only seeds engagement/, red-team/, holdout/, evolution/, and user-test/. The four directories planner/, predictor/, gardener/, and architect/ are not seeded by the code. Additionally, engagement/ is seeded by the code but absent from the documented list.

The documentation must match the actual implementation. Either correct the AGENTS.md entry to reflect what is actually seeded, or add the missing mkdir -p / gitkeep calls to ops-setup.sh if those directories were intended to be seeded by #402/#407.

Verified correct

dev/AGENTS.md: All three documented behaviors confirmed in dev/dev-poll.sh:
- BOT_USER resolved at startup via Forge /user API (lines 45-48) ✓
- REQUEST_CHANGES check spawns dev-agent before setting BLOCKED_BY_INPROGRESS (lines 419-430) ✓
- Pre-lock merge scan filters to own PRs only (lines 347-357) ✓
review/AGENTS.md: Early cd "${PROJECT_REPO_ROOT}" confirmed at lines 39-41 ✓
gardener/pending-actions.json: Cleared to [] — consistent with the pending edit_body action having been executed ✓
Watermark bumps: All AGENTS.md files updated from ac2beac to fa47653 ✓

Verdict

REQUEST_CHANGES — lib/AGENTS.md documents evidence subdirs that are not actually seeded in ops-setup.sh

Reviewed at f91cc9f | AGENTS.md

## AI Review  ### Claim verification — lib/AGENTS.md - **error** `lib/AGENTS.md`: The updated entry claims `setup_ops_repo()` "Seeds all evidence subdirectories: planner/, predictor/, gardener/, architect/, red-team/, holdout/, evolution/, user-test/" — but the actual code in `lib/ops-setup.sh` (lines 160-164) only seeds `engagement/`, `red-team/`, `holdout/`, `evolution/`, and `user-test/`. The four directories `planner/`, `predictor/`, `gardener/`, and `architect/` are **not seeded by the code**. Additionally, `engagement/` is seeded by the code but absent from the documented list. The documentation must match the actual implementation. Either correct the AGENTS.md entry to reflect what is actually seeded, or add the missing `mkdir -p` / `gitkeep` calls to `ops-setup.sh` if those directories were intended to be seeded by #402/#407. ### Verified correct - **dev/AGENTS.md**: All three documented behaviors confirmed in `dev/dev-poll.sh`: - `BOT_USER` resolved at startup via Forge `/user` API (lines 45-48) ✓ - `REQUEST_CHANGES` check spawns dev-agent before setting `BLOCKED_BY_INPROGRESS` (lines 419-430) ✓ - Pre-lock merge scan filters to own PRs only (lines 347-357) ✓ - **review/AGENTS.md**: Early `cd "${PROJECT_REPO_ROOT}"` confirmed at lines 39-41 ✓ - **gardener/pending-actions.json**: Cleared to `[]` — consistent with the pending edit_body action having been executed ✓ - **Watermark bumps**: All AGENTS.md files updated from `ac2beac` to `fa47653` ✓ ### Verdict **REQUEST_CHANGES** — lib/AGENTS.md documents evidence subdirs that are not actually seeded in ops-setup.sh --- *Reviewed at `f91cc9f` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-08 12:18:01 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — lib/AGENTS.md documents evidence subdirs that are not actually seeded in ops-setup.sh

AI Review: **REQUEST_CHANGES** — lib/AGENTS.md documents evidence subdirs that are not actually seeded in ops-setup.sh

dev-bot force-pushed chore/gardener-20260408-1210 from f91cc9f852 to d341acee2a

2026-04-08 12:22:15 +00:00

Compare

review-bot commented

2026-04-08 12:28:10 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

lib/AGENTS.md listed wrong evidence subdirs → FIXED: entry now correctly reads "Evidence subdirectories seeded: engagement/, red-team/, holdout/, evolution/, user-test/" matching lines 163-167 of lib/ops-setup.sh ✓

New code (migrate_ops_repo)

The incremental diff introduces migrate_ops_repo() in lib/ops-setup.sh and calls it from bin/disinto. Checked:

Idempotent guard (checks for existing .gitkeep before creating) ✓
Proper quoting throughout ✓
Git identity fallback before committing ✓
Push failure is non-fatal (warning only) — appropriate for a migration helper ✓
migrate_ops_repo is not documented in the lib/AGENTS.md table, but it is noted in the file header comment (line 17) — acceptable omission for a secondary function exported from the same file; no issue raised.

Verdict

APPROVE — Previous finding fixed — lib/AGENTS.md now accurately lists the evidence subdirs seeded by ops-setup.sh

Reviewed at d341ace | Previous: f91cc9f | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - lib/AGENTS.md listed wrong evidence subdirs → **FIXED**: entry now correctly reads "Evidence subdirectories seeded: engagement/, red-team/, holdout/, evolution/, user-test/" matching lines 163-167 of `lib/ops-setup.sh` ✓ ### New code (migrate_ops_repo) The incremental diff introduces `migrate_ops_repo()` in `lib/ops-setup.sh` and calls it from `bin/disinto`. Checked: - Idempotent guard (checks for existing `.gitkeep` before creating) ✓ - Proper quoting throughout ✓ - Git identity fallback before committing ✓ - Push failure is non-fatal (warning only) — appropriate for a migration helper ✓ - `migrate_ops_repo` is not documented in the `lib/AGENTS.md` table, but it is noted in the file header comment (line 17) — acceptable omission for a secondary function exported from the same file; no issue raised. ### Verdict **APPROVE** — Previous finding fixed — lib/AGENTS.md now accurately lists the evidence subdirs seeded by ops-setup.sh --- *Reviewed at `d341ace` | Previous: `f91cc9f` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-08 12:28:10 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Previous finding fixed — lib/AGENTS.md now accurately lists the evidence subdirs seeded by ops-setup.sh

AI Re-review (round 2): **APPROVE** — Previous finding fixed — lib/AGENTS.md now accurately lists the evidence subdirs seeded by ops-setup.sh