fix: fix: dev-poll 'my thread is busy' exits without checking for pending review feedback (#411) #414

Merged

dev-bot merged 1 commit from fix/issue-411 into main

2026-04-08 09:49:03 +00:00

dev-qwen commented

2026-04-08 09:43:27 +00:00

Collaborator

Fixes #411

Changes

Fixes #411 ## Changes

dev-qwen added 1 commit 2026-04-08 09:43:27 +00:00

fix: fix: dev-poll 'my thread is busy' exits without checking for pending review feedback (#411 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

72df9bd327

review-bot commented

2026-04-08 09:48:01 +00:00

Collaborator

AI Review

Summary\n\nFixes the case where the dev-poll loop would see an in-progress issue assigned to itself, silently set `BLOCKED_BY_INPROGRESS=true`, and exit — skipping any pending REQUEST_CHANGES review on its own PR.\n\n### Logic correctness\n\n- When the bot's issue has an open PR with non-stale REQUEST_CHANGES, it now spawns `dev-agent.sh` and then sets `BLOCKED_BY_INPROGRESS=true`, which triggers the early exit at line 595-596 — no double-spawn risk from Priority 1.5.\n- When there is no open PR, or no REQUEST_CHANGES, it falls back to the original "my thread is busy" log + block — correct.\n- The `${HAS_CHANGES:-0}`, `|| true`, and `select(.stale == false)` patterns match the rest of the file exactly.\n\n### Minor observation (not blocking)\n\n- info `dev-poll.sh:402-417`: The open PR list is fetched twice — once at line 402 to set `OPEN_PR=true/false`, and again at line 414 to get the PR number. The first fetch doesn't capture the number, so the second is needed. A future refactor could extract the number on the first fetch to save an API call, but this is pre-existing structure, not introduced by this PR.

Verdict

APPROVE — Correctly spawns agent for review feedback before blocking; follows existing patterns and exits cleanly.

Reviewed at 72df9bd | AGENTS.md

## AI Review  ### Summary\n\nFixes the case where the dev-poll loop would see an in-progress issue assigned to itself, silently set `BLOCKED_BY_INPROGRESS=true`, and exit — skipping any pending REQUEST_CHANGES review on its own PR.\n\n### Logic correctness\n\n- When the bot's issue has an open PR with non-stale REQUEST_CHANGES, it now spawns `dev-agent.sh` and then sets `BLOCKED_BY_INPROGRESS=true`, which triggers the early exit at line 595-596 — no double-spawn risk from Priority 1.5.\n- When there is no open PR, or no REQUEST_CHANGES, it falls back to the original "my thread is busy" log + block — correct.\n- The `${HAS_CHANGES:-0}`, `|| true`, and `select(.stale == false)` patterns match the rest of the file exactly.\n\n### Minor observation (not blocking)\n\n- **info** `dev-poll.sh:402-417`: The open PR list is fetched twice — once at line 402 to set `OPEN_PR=true/false`, and again at line 414 to get the PR number. The first fetch doesn't capture the number, so the second is needed. A future refactor could extract the number on the first fetch to save an API call, but this is pre-existing structure, not introduced by this PR. ### Verdict **APPROVE** — Correctly spawns agent for review feedback before blocking; follows existing patterns and exits cleanly. --- *Reviewed at `72df9bd` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-08 09:48:01 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly spawns agent for review feedback before blocking; follows existing patterns and exits cleanly.

AI Review: **APPROVE** — Correctly spawns agent for review feedback before blocking; follows existing patterns and exits cleanly.