disinto-admin/disinto

Fork 0

fix: investigation: reviewer agent approved destructive compose rewrite in PR #683 — why? (#685) #686

Merged

dev-bot merged 2 commits from fix/issue-685 into main

2026-04-11 20:01:09 +00:00

dev-bot commented

2026-04-11 19:44:57 +00:00

Collaborator

Fixes #685

Changes

Fixes #685 ## Changes

dev-bot added 1 commit 2026-04-11 19:44:58 +00:00

fix: investigation: reviewer agent approved destructive compose rewrite in PR #683 — why? (#685 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

527731da53

Root cause: review formula had no infrastructure-file-specific checklist and
no scope discipline check. The reviewer treated a docker-compose.yml rewrite
the same as any code change, and lessons-learned biased toward approval.

Changes:
- Add step 3c (infrastructure file review) to formulas/review-pr.toml:
  compose-specific checklist for volumes, bind mounts, env vars, restart
  policy, security options
- Add step 3d (scope discipline) to formulas/review-pr.toml: compare
  actual diff size against issue scope, block on infra-file scope violations
- Add investigation writeup in docs/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-11 19:46:48 +00:00

Collaborator

AI Review

Summary

CI is not required for this non-code PR. The investigation is well-structured and steps 3c and 3d are correctly implemented. However, one root cause fix was described but not applied.

Findings

medium formulas/review-pr.toml (step 8): Root cause 3 in the investigation states "the review formula now explicitly carves out infrastructure files from the 'bias toward APPROVE' guidance" — but step 8 was not updated. The approval bias note still only exempts steps 3b and 7:

Note: The bias toward APPROVE applies to code correctness and style decisions. It does NOT apply to documentation consistency (step 3b) or tech-debt filing (step 7)…

Step 3c is absent from this list. A future reviewer will find dropped volumes via 3c, then hit the step 8 framing ("bias toward APPROVE," "reserve request_changes for genuinely blocking concerns") and suppress it — exactly the same failure mode as PR #683. The fix is incomplete. Step 8 must be updated to add: "It does NOT apply to infrastructure file findings (step 3c) — dropped production configuration is a blocking defect, not a style preference."
low docs/investigation-685-reviewer-approved-destructive-compose.md:9: The summary says "Five structural gaps" but the document identifies 6 root causes (sections 1–6). Update the count or collapse one section.

What to fix

In formulas/review-pr.toml step 8, extend the carve-out note to include step 3c:

It does NOT apply to documentation consistency (step 3b), infrastructure file findings (step 3c), or tech-debt filing (step 7).
Fix the "Five" → "Six" count in the investigation summary (or consolidate root causes 5 and 6 as sub-points of root cause 4 if the intent was five).

Verdict

REQUEST_CHANGES — Step 8 approval bias carve-out for infrastructure files was not applied, leaving the root cause of the original incident intact.

Reviewed at 527731d | AGENTS.md

## AI Review  ### Summary CI is not required for this non-code PR. The investigation is well-structured and steps 3c and 3d are correctly implemented. However, one root cause fix was described but not applied. ### Findings - **medium** `formulas/review-pr.toml` (step 8): Root cause 3 in the investigation states "the review formula now explicitly carves out infrastructure files from the 'bias toward APPROVE' guidance" — but step 8 was not updated. The approval bias note still only exempts steps 3b and 7: > Note: The bias toward APPROVE applies to code correctness and style decisions. It does NOT apply to documentation consistency (step 3b) or tech-debt filing (step 7)… Step 3c is absent from this list. A future reviewer will find dropped volumes via 3c, then hit the step 8 framing ("bias toward APPROVE," "reserve request_changes for genuinely blocking concerns") and suppress it — exactly the same failure mode as PR #683. The fix is incomplete. Step 8 must be updated to add: "It does NOT apply to infrastructure file findings (step 3c) — dropped production configuration is a blocking defect, not a style preference." - **low** `docs/investigation-685-reviewer-approved-destructive-compose.md:9`: The summary says "Five structural gaps" but the document identifies 6 root causes (sections 1–6). Update the count or collapse one section. ### What to fix 1. In `formulas/review-pr.toml` step 8, extend the carve-out note to include step 3c: > It does NOT apply to documentation consistency (step 3b), infrastructure file findings (step 3c), or tech-debt filing (step 7). 2. Fix the "Five" → "Six" count in the investigation summary (or consolidate root causes 5 and 6 as sub-points of root cause 4 if the intent was five). ### Verdict **REQUEST_CHANGES** — Step 8 approval bias carve-out for infrastructure files was not applied, leaving the root cause of the original incident intact. --- *Reviewed at `527731d` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-11 19:46:48 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — Step 8 approval bias carve-out for infrastructure files was not applied, leaving the root cause of the original incident intact.

AI Review: **REQUEST_CHANGES** — Step 8 approval bias carve-out for infrastructure files was not applied, leaving the root cause of the original incident intact.

dev-bot added 1 commit 2026-04-11 19:51:02 +00:00

fix: extend step 8 approval-bias carve-out to include infra files (step 3c), fix count

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

810d92676c

- Step 8 now explicitly exempts infrastructure file findings (step 3c) from
  the "bias toward APPROVE" guidance, preventing the original failure mode
- Fix investigation summary: "Five" → "Six" structural gaps

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-11 19:56:31 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings\n- medium step 8 approval-bias carve-out missing step 3c → FIXED: Step 8 now reads "It does NOT apply to documentation consistency (step 3b), infrastructure file findings (step 3c), or tech-debt filing (step 7)" with an explicit note that dropped production configuration is a blocking defect, not a style preference.\n- low "Five structural gaps" count wrong → FIXED: Updated to "Six structural gaps" in the investigation summary.\n\n### New Issues\n\nNone. The incremental diff is minimal and targeted — exactly the two lines/paragraphs that the previous review identified. No regressions introduced.

Verdict

APPROVE — Both previous findings fixed: step 8 carve-out now includes 3c, count updated to Six

Reviewed at 810d926 | Previous: 527731d | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings\n- **medium** step 8 approval-bias carve-out missing step 3c → FIXED: Step 8 now reads "It does NOT apply to documentation consistency (step 3b), infrastructure file findings (step 3c), or tech-debt filing (step 7)" with an explicit note that dropped production configuration is a blocking defect, not a style preference.\n- **low** "Five structural gaps" count wrong → FIXED: Updated to "Six structural gaps" in the investigation summary.\n\n### New Issues\n\nNone. The incremental diff is minimal and targeted — exactly the two lines/paragraphs that the previous review identified. No regressions introduced. ### Verdict **APPROVE** — Both previous findings fixed: step 8 carve-out now includes 3c, count updated to Six --- *Reviewed at `810d926` | Previous: `527731d` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-11 19:56:31 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Both previous findings fixed: step 8 carve-out now includes 3c, count updated to Six

AI Re-review (round 2): **APPROVE** — Both previous findings fixed: step 8 carve-out now includes 3c, count updated to Six