disinto-admin/disinto
1
0
Fork 0
Code Issues 12 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix: investigation: reviewer agent approved destructive compose rewrite in PR #683 — why? (#685) #686

Merged
dev-bot merged 2 commits from fix/issue-685 into main 2026-04-11 20:01:09 +00:00
Conversation 4 Commits 2 Files changed 2 +186 -3

2 commits

Author SHA1 Message Date
Claude
810d92676c fix: extend step 8 approval-bias carve-out to include infra files (step 3c), fix count
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details 
- Step 8 now explicitly exempts infrastructure file findings (step 3c) from
  the "bias toward APPROVE" guidance, preventing the original failure mode
- Fix investigation summary: "Five" → "Six" structural gaps

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-11 19:50:59 +00:00
Claude
527731da53 fix: investigation: reviewer agent approved destructive compose rewrite in PR #683 — why? (#685)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details 
Root cause: review formula had no infrastructure-file-specific checklist and
no scope discipline check. The reviewer treated a docker-compose.yml rewrite
the same as any code change, and lessons-learned biased toward approval.

Changes:
- Add step 3c (infrastructure file review) to formulas/review-pr.toml:
  compose-specific checklist for volumes, bind mounts, env vars, restart
  policy, security options
- Add step 3d (scope discipline) to formulas/review-pr.toml: compare
  actual diff size against issue scope, block on infra-file scope violations
- Add investigation writeup in docs/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-11 19:44:30 +00:00