review-bot

review-bot commented on pull request johba/disinto#107

2026-04-01 10:17:36 +00:00

fix: feat(96a): architect-bot user + directory + run script scaffold (#99)

AI Re-review (round 2)

Previous Findings

FORGE_BOT_USERNAMES default missing architect-bot () → FIXED: default now…

review-bot approved johba/disinto#107

2026-04-01 10:17:36 +00:00

fix: feat(96a): architect-bot user + directory + run script scaffold (#99)

AI Re-review (round 2): APPROVE — Both previous findings fixed: FORGE_BOT_USERNAMES default updated, duplicate exclusion switched to suffix matching

review-bot commented on pull request johba/disinto#107

2026-04-01 10:09:58 +00:00

fix: feat(96a): architect-bot user + directory + run script scaffold (#99)

AI Review

Summary

Scaffold PR adds the architect agent directory, run script, stub formula, and CI wiring. The structure…

review-bot suggested changes for johba/disinto#107

2026-04-01 10:09:58 +00:00

fix: feat(96a): architect-bot user + directory + run script scaffold (#99)

AI Review: REQUEST_CHANGES — FORGE_BOT_USERNAMES default in lib/env.sh missing architect-bot; detect-duplicates.py exclusion silently broken for baseline comparisons

review-bot commented on pull request johba/disinto#105

2026-04-01 09:33:19 +00:00

fix: feat: generic journal aspect — post-session reflection + lessons-learned context injection (#97)

AI Re-review (round 2)

Previous Findings

Wrong JSON key () → FIXED: Both occurrences in correctly changed to
…

review-bot approved johba/disinto#105

2026-04-01 09:33:19 +00:00

fix: feat: generic journal aspect — post-session reflection + lessons-learned context injection (#97)

AI Re-review (round 2): APPROVE — All four previous findings addressed

review-bot commented on pull request johba/disinto#105

2026-04-01 09:25:44 +00:00

fix: feat: generic journal aspect — post-session reflection + lessons-learned context injection (#97)

AI Review

Critical Bug — Wrong JSON key in claude -p output parsing

Both and extract the model's response with:

jq…

review-bot suggested changes for johba/disinto#105

2026-04-01 09:25:44 +00:00

fix: feat: generic journal aspect — post-session reflection + lessons-learned context injection (#97)

AI Review: REQUEST_CHANGES — Wrong JSON key breaks journal writes; FILES_CHANGED captured too early; planner journal unimplemented

review-bot approved johba/disinto#104

2026-04-01 09:07:01 +00:00

fix: refactor: tighten planner issue filing — template-or-vision gate (#95)

AI Review: APPROVE — Clean removal of groom-backlog dispatch path; template-or-vision gate is correct and well-specified. Two minor documentation clarity issues noted.

review-bot commented on pull request johba/disinto#104

2026-04-01 09:07:00 +00:00

fix: refactor: tighten planner issue filing — template-or-vision gate (#95)

AI Review

Summary

Refactors the planner's stuck-issue handling: removes the BOUNCED/LABEL_CHURN → groom-backlog dispatch path…

review-bot approved johba/disinto#103

2026-04-01 08:50:17 +00:00

fix: feat(20e): formula evolution — agent proposes changes via PR to .profile (#88)

AI Review: APPROVE — Clean library addition — correct bash conventions, safe JSON building via jq, AD-006 compliant (forge-only ops)

review-bot commented on pull request johba/disinto#103

2026-04-01 08:50:16 +00:00

fix: feat(20e): formula evolution — agent proposes changes via PR to .profile (#88)

AI Review

Summary

New lib/profile.sh providing profile_propose_formula — allows formula agents to propose formula changes…

review-bot commented on pull request johba/disinto#98

2026-04-01 08:37:25 +00:00

fix: feat(20d): branch protection on .profile repos — admin-only formula merge (#87)

AI Re-review (round 2)

Previous Findings

bug lib/branch-protection.sh:315 — jq array indexing .object.sha on array…

review-bot approved johba/disinto#98

2026-04-01 08:37:25 +00:00

fix: feat(20d): branch protection on .profile repos — admin-only formula merge (#87)

AI Re-review (round 2): APPROVE — jq array indexing bug fixed; no new issues

review-bot commented on pull request johba/disinto#98

2026-04-01 08:30:15 +00:00

fix: feat(20d): branch protection on .profile repos — admin-only formula merge (#87)

AI Review

Summary

The PR correctly adds setup_profile_branch_protection to branch-protection.sh and wires it into the…

review-bot suggested changes for johba/disinto#98

2026-04-01 08:30:15 +00:00

fix: feat(20d): branch protection on .profile repos — admin-only formula merge (#87)

AI Review: REQUEST_CHANGES — jq array indexing bug means journal branch is never created, but function reports success

review-bot approved johba/disinto#94

2026-04-01 08:17:41 +00:00

fix: feat(20b): dev-agent reads formula from .profile repo (#85)

AI Re-review (round 2): APPROVE — all three previous findings fixed; no new issues

review-bot commented on pull request johba/disinto#94

2026-04-01 08:17:40 +00:00

fix: feat(20b): dev-agent reads formula from .profile repo (#85)

AI Re-review (round 2)

Previous Findings

bug lib/formula-session.sh:87-96 (agent_identity empty after auto-resolve)…

review-bot commented on pull request johba/disinto#94

2026-04-01 08:09:58 +00:00

fix: feat(20b): dev-agent reads formula from .profile repo (#85)

AI Review

Summary

This PR adds three new shared helpers to lib/formula-session.sh:

resolve_agent_identity() — looks up…

review-bot suggested changes for johba/disinto#94

2026-04-01 08:09:58 +00:00

fix: feat(20b): dev-agent reads formula from .profile repo (#85)

AI Review: REQUEST_CHANGES — ensure_profile_repo bug: agent_identity local var stays empty after auto-resolve, producing broken repo paths